Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse Event for OnSend Callbacks #1517

Merged
merged 5 commits into from
Nov 22, 2021
Merged

Parse Event for OnSend Callbacks #1517

merged 5 commits into from
Nov 22, 2021

Conversation

lemnik
Copy link
Contributor

@lemnik lemnik commented Nov 16, 2021

Goal

Parse Event objects from stored events, so that they can be processed by registered OnSendCallbacks.

Testing

Added a deserialization test to EventSerializationTest

@lemnik lemnik requested a review from kattrali November 16, 2021 17:15
@lemnik lemnik force-pushed the PLAT-7611/parse-event-for-onsend branch from a885811 to 73f715b Compare November 19, 2021 16:34
@lemnik lemnik changed the base branch from next to integration/onsend-next November 19, 2021 16:41
@lemnik lemnik force-pushed the PLAT-7611/parse-event-for-onsend branch from 73f715b to 0517b34 Compare November 19, 2021 16:51
@lemnik lemnik marked this pull request as ready for review November 19, 2021 17:04
kattrali
kattrali approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

bugsnag-android-core/src/main/java/com/bugsnag/android/MarshalledEventSource.kt Outdated
@@ -29,6 +33,11 @@ internal class MarshalledEventSource(private val eventFile: File) : () -> Event

@Suppress("StopShip")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can go now! 😄

@lemnik lemnik force-pushed the PLAT-7611/parse-event-for-onsend branch from 0517b34 to dc0fdae Compare November 22, 2021 10:30
@lemnik lemnik merged commit 640d592 into integration/onsend-next Nov 22, 2021
@lemnik lemnik deleted the PLAT-7611/parse-event-for-onsend branch November 22, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lemnik @kattrali